Commit 704e7db

mokha <mokha@cisco.com>
2019-05-03 18:45:32
use String.join and System.lineSeparator
1 parent b9e941c
Changed files (2)
assignments
assignment1
src
main
java
ca
mokhan
test
java
ca
assignments/assignment1/src/main/java/ca/mokhan/assignment1/BanffMarathonRunner.java
@@ -51,7 +51,7 @@ public class BanffMarathonRunner extends AddressBook
 
     for (BanffMarathonRunner runner : runners) {
       if (runner.time >= average) {
-        result += runner.toString() + "\r\n";
+        result += runner.toString() + System.lineSeparator();
       }
     }
     return result;
assignments/assignment1/src/test/java/ca/mokhan/assignment1/BanffMarathonRunnerTest.java
@@ -53,13 +53,17 @@ public class BanffMarathonRunnerTest extends TestCase
 
   public void testGetAboveAverageRunners()
   {
-    String expected = "Elena 1\r\n" +
-      "Suzie 7\r\n" +
-      "Philip 9\r\n" +
-      "James 1\r\n" +
-      "Jane 1\r\n" +
-      "Emily 4\r\n" +
-      "Neda 3\r\n";
+    String expected = String.join(
+      System.lineSeparator(),
+      "Elena 1",
+      "Suzie 7",
+      "Philip 9",
+      "James 1",
+      "Jane 1",
+      "Emily 4",
+      "Neda 3",
+      ""
+    );
     assertEquals(expected, BanffMarathonRunner.getAboveAverageRunners(this.runners));
   }
 }