Commit f8ddac3e

mo khan <mo@mokhan.ca>
2013-07-03 15:01:38
refactor to use unobtrusive convention to track mix panel links using .mix-link and data-event attributes
1 parent 5077443
Changed files (3)
app/views/creations/show.html.erb
@@ -5,11 +5,6 @@
 $(function() { 
   Creations.Show.initialize(); 
   mixpanel.track_forms(".form-horizontal", "commented");
-  mixpanel.track_links(".add-to-favorites", "click-add-to-favorites", {'referrer': document.referrer });
-  mixpanel.track_links(".sign-up", "click-sign-up", {'referrer': document.referrer });
-  mixpanel.track_links(".tag-link", "click-on-tag", {'referrer': document.referrer });
-  mixpanel.track_links("#add-comment-button", "click-on-add-comment", {'referrer': document.referrer });
-  mixpanel.track_links("#sign-in-to-comment", "click-on-sign-in-to-comment", {'referrer': document.referrer });
 });
 </script>
 <% end -%>
@@ -38,7 +33,7 @@ $(function() {
     <% if @creation.tags.any? %>
       <span> <i class="icon-tags"></i> </span>
       <% @creation.tags.each do |tag| -%>
-        <a href="<%= url_for creation_tag_path(tag.name) %>" class="tag-link"><span class="label"><%= tag.name %></span></a>
+        <a href="<%= url_for creation_tag_path(tag.name) %>" class="mix-link" data-event="click-on-tag"><span class="label"><%= tag.name %></span></a>
       <% end -%>
     <% end -%>
     <hr />
@@ -46,10 +41,10 @@ $(function() {
       <div class="span3">
         <% if user_signed_in? %>
           <% unless current_user == @creation.user || current_user.already_likes(@creation) %>
-          <%= button_to "ADD TO FAVORITES", creation_favorites_path(:creation_id => @creation.id), :method => :post, :id => 'add-to-favorites', :class => 'btn btn-primary' %>
+            <%= button_to "ADD TO FAVORITES", creation_favorites_path(:creation_id => @creation.id), :method => :post, :class => 'btn btn-primary mix-link', "data-event" => 'click-add-to-favorites' %>
       <% end %>
       <% else %>
-        <p><%= link_to "SIGN UP FOR FREE", new_user_session_path, :id => 'sign-up', :class => "btn btn-primary" %></p>
+        <p><%= link_to "SIGN UP FOR FREE", new_user_session_path, :class => "btn btn-primary mix-link", "data-event" => 'click-sign-up' %></p>
       <% end %>
       </div>
       <div class="span3">
@@ -87,9 +82,9 @@ $(function() {
   <div class="span12">
     <h3>Comments <small><%= pluralize @comments.length, "comment" %></small></h3>
     <% unless user_signed_in? %>
-      <p><%= link_to "SIGN IN", new_user_session_path, :id => "sign-in-to-comment", :class => "btn btn-primary" %> to comment </p>
+      <p><%= link_to "SIGN IN", new_user_session_path, :class => "btn btn-primary mix-link", "data-event" => "click-on-sign-in-to-comment" %> to comment </p>
   <% else %>
-      <p><a id="add-comment-button" class="btn btn-large btn-primary" data-toggle="modal" href="#add-comment-dialog"><i class="icon-comment"> </i>COMMENT</a></p>
+      <p><a id="add-comment-button" class="btn btn-large btn-primary mix-link" data-event="click-on-add-comment" data-toggle="modal" href="#add-comment-dialog"><i class="icon-comment"> </i>COMMENT</a></p>
   <% end -%>
     <% @comments.each do |comment| %>
       <div class="row">
app/views/profiles/show.html.erb
@@ -27,7 +27,7 @@
       <h4>Other Artists Nearby</h4>
       <ul class="unstyled">
       <% @nearby_users.each do |item| %>
-        <li><%= link_to item.name, profile_path(item) %> <small>(<%= item.city %>)</small></li>
+        <li><%= link_to item.name, profile_path(item), :class => "mix-link", "data-event" => "click-on-nearby-user" %> <small>(<%= item.city %>)</small></li>
       <% end %>
       <%= image_tag @map_url %>
       </ul>
app/views/shared/_creation_image_gallery.html.erb
@@ -2,8 +2,8 @@
   <% @creations.each do |creation| %>
     <li class="span3">
     <div class="thumbnail">
-      <a href="<%= url_for creation %>"><img src="<%= creation.primary_image.image.thumb.url %>" alt="<%= creation.name %>" style="width:260px;height:180px;" /></a>
-      <h3><a href="<%= url_for creation %>"><%= short_name(creation, 15) %></a></h3>
+      <a href="<%= url_for creation %>" class="mix-link" data-event="click-on-thumbnail"><img src="<%= creation.primary_image.image.thumb.url %>" alt="<%= creation.name %>" style="width:260px;height:180px;" /></a>
+      <h3><a href="<%= url_for creation %>" class="mix-link" data-event="click-on-title"><%= short_name(creation, 15) %></a></h3>
       <h4><small>By <a href="<%= url_for profile_path(creation.user) %>"><%= shrink(creation.user.name, 20) %></a></small></h4>
       <p>
       <a href="<%= url_for creation_favorites_path(:creation_id => creation.id) %>"><span class="badge"><%= creation.favorites.size %> <i class="icon-heart-empty"></i></span></a>