Commit 6bb6fdb

mo <mo@mokhan.ca>
2018-05-07 21:23:33
do not accept default headers in ctor. tag: v0.1.2
1 parent 54ab2db
Changed files (3)
lib/net/hippie/client.rb
@@ -8,14 +8,13 @@ module Net
       }
 
       def initialize(
-        headers: {},
         certificate: nil,
         key: nil,
         passphrase: nil,
         mapper: JsonMapper.new
       )
         @certificate = certificate
-        @default_headers = DEFAULT_HEADERS.merge(headers)
+        @default_headers = DEFAULT_HEADERS
         @key = key
         @mapper = mapper
       end
test/net/client_test.rb
@@ -5,9 +5,7 @@ class Net::Hippie::ClientTest < Minitest::Test
 
   def initialize(*args)
     super
-    @subject = Net::Hippie::Client.new(headers: {
-      'Accept' => 'application/vnd.haveibeenpwned.v2+json'
-    })
+    @subject = Net::Hippie::Client.new
   end
 
   def test_get
@@ -31,7 +29,7 @@ class Net::Hippie::ClientTest < Minitest::Test
   end
 
   def test_get_with_headers
-    headers = { 'User-Agent' => 'example/agent' }
+    headers = { 'Accept' => 'application/vnd.haveibeenpwned.v2+json' }
     WebMock.stub_request(:get, 'https://haveibeenpwned.com/api/breaches')
       .with(headers: headers)
       .to_return(status: 201, body: {}.to_json)
README.md
@@ -26,12 +26,21 @@ require 'net/hippie'
 
 Net::Hippie.logger = Rails.logger
 
-client = Net::Hippie::Client.new(headers: {
+client = Net::Hippie::Client.new
+
+headers = {
   'Accept' => 'application/vnd.haveibeenpwned.v2+json'
-})
+}
 
-response = client.get(URI.parse('https://haveibeenpwned.com/api/breaches'))
+uri = URI.parse('https://haveibeenpwned.com/api/breaches')
+response = client.get(uri, headers: headers)
+puts JSON.parse(response.body)
+```
 
+```ruby
+client = Net::Hippie::Client.new
+body = { user: { name: 'hippie' } }
+response = client.post(URI.parse('https://example.com'), body: body)
 puts JSON.parse(response.body)
 ```