Comparing changes

v0.2.1 → v0.2.2

4 commits 3 files changed

Commits

c9117d6 Merge pull request #1 from awebz/open_timeout mo khan 2019-02-01 21:31:24

51b686b compacting definition of attr_accessors azohoori 2019-02-01 21:23:47

b214fb8 bumps up the gem version azohoori 2019-02-01 20:51:40

321a5d1 adding open timeout attribute azohoori 2019-02-01 20:49:42

Changed files (3)

lib

net

hippie

client.rb

version.rb

test

net

client_test.rb

lib/net/hippie/client.rb

@@ -10,9 +10,7 @@ module Net
         'User-Agent' => "net/hippie #{Net::Hippie::VERSION}"
       }.freeze
 
-      attr_accessor :mapper
-      attr_accessor :read_timeout
-      attr_accessor :logger
+      attr_accessor :mapper, :read_timeout, :open_timeout, :logger
 
       def initialize(
         certificate: nil,
@@ -99,6 +97,7 @@ module Net
       def http_for(uri)
         http = Net::HTTP.new(uri.host, uri.port)
         http.read_timeout = read_timeout
+        http.open_timeout = open_timeout if open_timeout
         http.use_ssl = uri.scheme == 'https'
         http.verify_mode = verify_mode
         http.set_debug_output(logger)

lib/net/hippie/version.rb

@@ -2,6 +2,6 @@
 
 module Net
   module Hippie
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'
   end
 end

test/net/client_test.rb

@@ -229,4 +229,10 @@ class ClientTest < Minitest::Test
     end
     assert(@called)
   end
+
+  def test_open_timeout_setting
+    assert_equal subject.open_timeout, nil
+    @subject.open_timeout = 10
+    assert_equal subject.open_timeout, 10
+  end
 end