Comparing changes
v0.2.2
→
v0.2.3
6 commits
9 files changed
Commits
Changed files (9)
bin
lib
net
hippie
test
bin/cibuild
@@ -18,6 +18,6 @@ export RUBY_HEAP_SLOTS_GROWTH_FACTOR=1
export CIBUILD=1
ruby -v
-gem install bundler --no-ri --no-rdoc --conservative
+gem install bundler --conservative
bin/test
bin/lint
lib/net/hippie/client.rb
@@ -17,7 +17,7 @@ module Net
headers: DEFAULT_HEADERS,
key: nil,
passphrase: nil,
- verify_mode: nil
+ verify_mode: Net::Hippie.verify_mode
)
@certificate = certificate
@default_headers = headers
lib/net/hippie/version.rb
@@ -2,6 +2,6 @@
module Net
module Hippie
- VERSION = '0.2.2'
+ VERSION = '0.2.3'
end
end
lib/net/hippie.rb
@@ -30,6 +30,14 @@ module Net
@logger = logger
end
+ def self.verify_mode
+ @verify_mode ||= OpenSSL::SSL::VERIFY_PEER
+ end
+
+ def self.verify_mode=(mode)
+ @verify_mode = mode
+ end
+
def self.basic_auth(username, password)
"Basic #{::Base64.strict_encode64("#{username}:#{password}")}"
end
test/net/client_test.rb
@@ -231,7 +231,7 @@ class ClientTest < Minitest::Test
end
def test_open_timeout_setting
- assert_equal subject.open_timeout, nil
+ assert_nil subject.open_timeout
@subject.open_timeout = 10
assert_equal subject.open_timeout, 10
end
test/net/hippie_test.rb
@@ -1,6 +1,10 @@
require 'test_helper'
class HippieTest < Minitest::Test
+ def teardown
+ Net::Hippie.verify_mode = OpenSSL::SSL::VERIFY_PEER
+ end
+
def test_that_it_has_a_version_number
refute_nil ::Net::Hippie::VERSION
end
@@ -8,4 +12,13 @@ class HippieTest < Minitest::Test
def test_it_does_something_useful
assert true
end
+
+ def test_it_has_a_default_verify_mode
+ assert Net::Hippie.verify_mode == OpenSSL::SSL::VERIFY_PEER
+ end
+
+ def test_it_can_customize_the_verify_mode
+ Net::Hippie.verify_mode = OpenSSL::SSL::VERIFY_NONE
+ assert Net::Hippie.verify_mode == OpenSSL::SSL::VERIFY_NONE
+ end
end
.gitlab-ci.yml
@@ -1,4 +1,4 @@
-image: ruby:2.5
+image: ruby:2.6
before_script:
- apt-get update && apt-get install -y locales
.travis.yml
@@ -1,9 +1,9 @@
sudo: false
language: ruby
-cache: bundler
rvm:
- 2.3.8
- 2.4.5
- 2.5.3
+ - 2.6.0
script:
- bin/cibuild
net-hippie.gemspec
@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']
- spec.add_development_dependency 'bundler', '~> 1.16'
spec.add_development_dependency 'minitest', '~> 5.0'
spec.add_development_dependency 'rake', '~> 10.0'
spec.add_development_dependency 'rubocop', '~> 0.55'