Comparing changes

@@ -0,0 +1,31 @@
+name: ci
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - name: Running tests…
+        run: sh bin/test
+  style:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.4'
+          bundler-cache: true
+      - name: Running style checks…
+        run: sh bin/style

.github/workflows/test.yml

@@ -1,17 +0,0 @@
-name: Test
-
-on: [push, pull_request]
-
-jobs:
-  test:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        ruby: [ '2.5', '2.6', '2.7' ]
-    steps:
-    - uses: actions/checkout@v1
-    - uses: actions/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby }}
-    - name: cibuild
-      run: bin/cibuild

.github/dependabot.yml

@@ -0,0 +1,9 @@
+---
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    assignees:
+      - "xlgmokha"

bin/cibuild

@@ -1,22 +0,0 @@
-#!/bin/sh
-
-set -e
-[ -z "$DEBUG" ] || set -x
-
-cd "$(dirname "$0")/.."
-
-export RUBY_GC_MALLOC_LIMIT=79000000
-export RUBY_GC_HEAP_INIT_SLOTS=800000
-export RUBY_HEAP_FREE_MIN=100000
-export RUBY_HEAP_SLOTS_INCREMENT=400000
-export RUBY_HEAP_SLOTS_GROWTH_FACTOR=1
-export CIBUILD=1
-
-echo "[$(date "+%H:%M:%S")] ==> Running setup…"
-bin/setup
-
-echo "[$(date "+%H:%M:%S")] ==> Running tests…"
-bin/test
-
-echo "[$(date "+%H:%M:%S")] ==> Running linters…"
-bin/lint

bin/console

@@ -4,12 +4,5 @@
 require 'bundler/setup'
 require 'net/hippie'
 
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
 require 'irb'
 IRB.start(__FILE__)

bin/lint

@@ -1,5 +0,0 @@
-#!/bin/sh
-
-set -e
-
-bundle exec rake lint

bin/setup

@@ -1,7 +1,7 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
+#!/bin/sh
+set -e
+[ -z "$DEBUG" ] || set -x
+
+cd "$(dirname "$0")/.."
 
-ruby -v
-gem install bundler -v '~> 2.0'
 bundle install

bin/shipit

@@ -1,10 +1,8 @@
 #!/bin/sh
 
 set -e
+[ -z "$DEBUG" ] || set -x
 
 cd "$(dirname "$0")/.."
 
-[ -z "$DEBUG" ] || set -x
-
-bin/cibuild
 bundle exec rake release

bin/style

@@ -0,0 +1,8 @@
+#!/bin/sh
+
+set -e
+[ -z "$DEBUG" ] || set -x
+
+cd "$(dirname "$0")/.."
+
+bundle exec rake rubocop

bin/test

@@ -1,6 +1,7 @@
 #!/bin/sh
 
 set -e
+[ -z "$DEBUG" ] || set -x
 
 cd "$(dirname "$0")/.."

lib/net/hippie/client.rb

@@ -84,7 +84,7 @@ module Net
         raise error if attempt == max
 
         delay = ((2**attempt) * 0.1) + Random.rand(0.05) # delay + jitter
-        logger.warn("`#{error.message}` #{attempt + 1}/#{max} Delay: #{delay}s")
+        logger&.warn("`#{error.message}` #{attempt + 1}/#{max} Delay: #{delay}s")
         sleep delay
       end

lib/net/hippie/connection.rb

@@ -10,7 +10,7 @@ module Net
         http.open_timeout = options.fetch(:open_timeout, 10)
         http.use_ssl = scheme == 'https'
         http.verify_mode = options.fetch(:verify_mode, Net::Hippie.verify_mode)
-        http.set_debug_output(options.fetch(:logger, Net::Hippie.logger))
+        http.set_debug_output(options[:logger]) if options[:logger]
         apply_client_tls_to(http, options)
         @http = http
       end

lib/net/hippie/version.rb

@@ -2,6 +2,6 @@
 
 module Net
   module Hippie
-    VERSION = '1.1.1'
+    VERSION = '1.2.0'
   end
 end

lib/net/hippie.rb

@@ -31,7 +31,7 @@ module Net
     ].freeze
 
     def self.logger
-      @logger ||= Logger.new($stderr)
+      @logger ||= Logger.new(nil)
     end
 
     def self.logger=(logger)

test/fixtures/get_root.yml

@@ -3,18 +3,11 @@ http_interactions:
 - request:
     method: get
     uri: https://www.mokhan.ca/
-    body:
-      encoding: US-ASCII
-      string: ''
     headers:
       Accept:
       - application/json
       Content-Type:
       - application/json
-      User-Agent:
-      - net/hippie 0.2.4
-      Accept-Encoding:
-      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
   response:
     status:
       code: 200
@@ -30,22 +23,10 @@ http_interactions:
       - Wed, 05 Dec 2018 08:57:44 GMT
       Last-Modified:
       - Wed, 05 Dec 2018 05:45:13 GMT
-      Server:
-      - AmazonS3
-      Vary:
-      - Accept-Encoding
-      Age:
-      - '53062'
-      X-Cache:
-      - Hit from cloudfront
-      Via:
-      - 1.1 39174a6a452e175e6e614ff396a4ca4f.cloudfront.net (CloudFront)
-      X-Amz-Cf-Id:
-      - mGugayoZK2mUAfj9WuV5O9c9_uzocRazyLFGqNdDjKQpniAmpFU6gA==
     body:
       encoding: ASCII-8BIT
       string: !binary |-
         <!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset='utf-8'>
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="referrer" content="no-referrer">
    <link rel="canonical" href="https://www.mokhan.ca/">
    <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
<link rel="manifest" href="/site.webmanifest">
<meta name="msapplication-TileColor" content="#da532c">
<meta name="theme-color" content="#ffffff">

    <!-- Begin Jekyll SEO tag v2.5.0 -->
<title>mo khan | My thoughts belong to me</title>
<meta name="generator" content="Jekyll v3.8.5" />
<meta property="og:title" content="mo khan" />
<meta name="author" content="mo" />
<meta property="og:locale" content="en" />
<meta name="description" content="My thoughts belong to me" />
<meta property="og:description" content="My thoughts belong to me" />
<link rel="canonical" href="https://www.mokhan.ca/" />
<meta property="og:url" content="https://www.mokhan.ca/" />
<meta property="og:site_name" content="mo khan" />
<script type="application/ld+json">
{"@type":"WebSite","headline":"mo khan","url":"https://www.mokhan.ca/","publisher":{"@type":"Organization","logo":{"@type":"ImageObject","url":"https://www.mokhan.ca/images/avatar.jpg"},"name":"mo"},"name":"mo khan","author":{"@type":"Person","name":"mo"},"description":"My thoughts belong to me","@context":"http://schema.org"}</script>
<!-- End Jekyll SEO tag -->

    <link type="application/atom+xml" rel="alternate" href="https://www.mokhan.ca/atom.xml" title="mo khan" />
    <link rel="stylesheet" integrity="sha256-hQZZ6gi+pyIpYo9loSb495pS0K5zcBlRNxPu80eCuD8=" crossorigin="anonymous" href="/assets/style-850659ea08bea72229628f65a126f8f79a52d0ae737019513713eef34782b83f.css">
    <script src="/assets/js/application.js" async></script>
  <script async src="https://www.googletagmanager.com/gtag/js?id=UA-242918-1"></script>
</head>
  <body>
    <main>
      <a href="#main_content" class="skip">Skip to content</a>
      <div class="container">
        <section id="main_content">
          <h1 id="hi-my-name-is-mo">Hi, my name is <code class="highlighter-rouge">Mo</code></h1>

<p><strong>tl;dr</strong> <a href="https://github.com/mokhan/">GitHub</a>, <a href="https://rubygems.org/profiles/mokha">RubyGems</a>, <a href="https://www.linkedin.com/in/mokhancalgary">LinkedIn</a></p>

<hr />

<p>I ♥ <a href="https://www.ruby-lang.org/">Ruby</a>. It’s a very fun and
expressive programming language.</p>

<div class="language-ruby highlighter-rouge"><div class="highlight"><pre class="highlight"><code><span class="c1"># moo.rb</span>
<span class="nb">require</span> <span class="s1">'bundler/inline'</span>                         <span class="c1"># も ruby moo.rb</span>
                                                 <span class="c1">#   ----</span>
<span class="n">gemfile</span> <span class="k">do</span>                                       <span class="c1"># &lt; moo! &gt;</span>
  <span class="n">source</span> <span class="s1">'https://rubygems.org'</span>                  <span class="c1">#   ----</span>
  <span class="n">gem</span> <span class="s1">'net-hippie'</span>                               <span class="c1">#         \   ^__^</span>
<span class="k">end</span>                                              <span class="c1">#          \  (oo)\_______</span>
<span class="n">client</span> <span class="o">=</span> <span class="no">Net</span><span class="o">::</span><span class="no">Hippie</span><span class="o">::</span><span class="no">Client</span><span class="p">.</span><span class="nf">new</span>                 <span class="c1">#             (__)\       )\/\</span>
<span class="n">url</span> <span class="o">=</span> <span class="s2">"https://www.mokhan.ca/"</span>                   <span class="c1">#                 ||----w |</span>
<span class="n">body</span> <span class="o">=</span> <span class="n">client</span><span class="p">.</span><span class="nf">get</span><span class="p">(</span><span class="n">url</span><span class="p">).</span><span class="nf">body</span>                      <span class="c1">#                 ||     ||</span>
<span class="nb">puts</span> <span class="n">body</span><span class="p">[</span><span class="o">-</span><span class="mi">150</span><span class="o">..-</span><span class="mi">1</span><span class="p">]</span>                              <span class="c1"># --&gt;</span>

</code></pre></div></div>

<p>I wrote <a href="https://rubygems.org/gems/saml-kit">saml-kit</a>,
<a href="https://rubygems.org/gems/net-hippie">net-hippie</a>,
<a href="https://rubygems.org/gems/incognito">incognito</a>,
<a href="https://rubygems.org/gems/xsay">xsay</a>,
<a href="https://rubygems.org/gems/del">del</a> and many more gems.</p>

<div class="language-ruby highlighter-rouge"><div class="highlight"><pre class="highlight"><code><span class="c1">#!/bin/sh</span>
<span class="n">gem</span> <span class="n">install</span> <span class="n">xsay</span>                                 <span class="c1"># も xsay random Hello</span>
<span class="n">xsay</span> <span class="n">random</span> <span class="no">Hello</span>                                <span class="c1">#   -----</span>
                                                 <span class="c1"># &lt; Hello &gt;</span>
                                                 <span class="c1">#   -----</span>
                                                 <span class="c1">#       ."`".</span>
                                                 <span class="c1">#   .-./ _=_ \.-.</span>
                                                 <span class="c1">#  {  (,(oYo),)  }</span>
                                                 <span class="c1">#  {  |   "   |  }</span>
                                                 <span class="c1">#  { { \(---)/ } }</span>
                                                 <span class="c1">#  { { }'-=-'{ } }</span>
                                                 <span class="c1">#  { { }._:_.{ } }</span>
                                                 <span class="c1">#  { { } -:- { } }</span>
                                                 <span class="c1">#  {_{ }`===`{  _}</span>
                                                 <span class="c1"># ((((\)     (/))))</span>

</code></pre></div></div>

          <hr />
        </section>
      </div>
    </main>
    <footer>
      <img class="center" integrity="sha256-0OOxgeimIJlnsTPk5io3mFOS08hEWvXZwGRJwHkbpYk=" crossorigin="anonymous" src="/assets/1b2647-1dc1e940eb4b2d42eeaa8ccb4bdf1365c7d2f72afc930cff8192dc553c7e1b43.jpg">
      <p class="text-center">My thoughts belong to me<a href="/❤️.html" class="category">.</a></p>
      <p class="text-center">
        <a href="https://github.com/mokhan/">GitHub</a> |
        <a href="https://rubygems.org/profiles/mokha">RubyGems</a> |
        <a href="https://www.linkedin.com/in/mokhancalgary">LinkedIn</a>
      </p>
      <p class="text-center">
        &copy; 2005-2018
        mo [at] mokhan [dot] ca
        <a href="https://www.mokhan.ca">www.mokhan.ca</a>
      </p>
    </footer>
  <script>
  window.dataLayer = window.dataLayer || [];
  function gtag(){dataLayer.push(arguments);}
  gtag('js', new Date());
  gtag('config', 'UA-242918-1', {
    'page_title': 'mo khan',
    'page_location': 'https://www.mokhan.ca/',
    'page_path': '/',
    'anonymize_ip': true,
  });
</script>
</body>
</html>
<!--
 _____
< moo >
 -----
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||
-->


-    http_version: 
+    http_version:
   recorded_at: Wed, 06 Feb 2019 17:45:16 GMT
 recorded_with: VCR 4.0.0

test/net/client_test.rb

@@ -3,8 +3,7 @@ require 'test_helper'
 class ClientTest < Minitest::Test
   attr_reader :subject
 
-  def initialize(*args)
-    super
+  def setup
     @subject = Net::Hippie::Client.new
   end
 
@@ -303,4 +302,19 @@ class ClientTest < Minitest::Test
     end
     assert(@called)
   end
+
+  def test_logger
+    VCR.turned_off do
+      WebMock.allow_net_connect!
+      StringIO.open do |io|
+        subject = Net::Hippie::Client.new(logger: Logger.new(io, level: :debug))
+        response = subject.get('https://www.example.org/')
+
+        refute_nil response
+        assert_kind_of Net::HTTPOK, response
+        io.rewind
+        assert_match %r{^(opening connection to www.example.org:443)}, io.read
+      end
+    end
+  end
 end

test/test_helper.rb

@@ -6,8 +6,7 @@ require 'net/hippie'
 require 'securerandom'
 require 'vcr'
 require 'webmock'
-
-Net::Hippie.logger = ENV['CIBUILD'] ? Logger.new('/dev/null') : Logger.new(STDERR)
+require 'webmock/minitest'
 
 VCR.configure do |config|
   config.cassette_library_dir = 'test/fixtures'

.gitlab-ci.yml

@@ -1,11 +0,0 @@
-image: ruby:2.6
-
-before_script:
-  - apt-get update && apt-get install -y locales
-  - echo "en_US.UTF-8 UTF-8" > /etc/locale.gen
-  - locale-gen
-  - export LC_ALL=en_US.UTF-8
-
-ci:
-  script:
-    - bin/cibuild

.rubocop.yml

@@ -8,6 +8,9 @@ AllCops:
   NewCops: enable
   TargetRubyVersion: 2.5
 
+Gemspec/DevelopmentDependencies:
+  EnforcedStyle: gemspec
+
 Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation

CHANGELOG.md

@@ -1,4 +1,4 @@
-Version 1.1.1
+Version 1.2.0
 
 # Changelog
 All notable changes to this project will be documented in this file.
@@ -7,9 +7,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+## [1.2.0] - 2024-12-05
+### Changed
+- Disable logger by default
+
 ## [1.1.1] - 2021-01-30
 ### Changed
-- Update 
+- Update Gem Metadata
 
 ## [1.1.0] - 2020-12-26
 ### Added
@@ -80,7 +84,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - with\_retry.
 - authorization header helpers
 
-[Unreleased]: https://github.com/xlgmokha/net-hippie/compare/v1.1.0...HEAD
+[Unreleased]: https://github.com/xlgmokha/net-hippie/compare/v1.2.0...HEAD
+[1.2.0]: https://github.com/xlgmokha/net-hippie/compare/v1.1.1...v1.2.0
+[1.1.1]: https://github.com/xlgmokha/net-hippie/compare/v1.1.0...v1.1.1
 [1.1.0]: https://github.com/xlgmokha/net-hippie/compare/v1.0.1...v1.1.0
 [1.0.1]: https://github.com/xlgmokha/net-hippie/compare/v1.0.0...v1.0.1
 [1.0.0]: https://github.com/xlgmokha/net-hippie/compare/v0.3.2...v1.0.0

LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 mo
+Copyright (c) 2018 mo khan
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

net-hippie.gemspec

@@ -15,7 +15,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://rubygems.org/gems/net-hippie'
   spec.license       = 'MIT'
   spec.metadata      = {
-    'source_code_uri' => 'https://github.com/xlgmokha/net-hippie'
+    'source_code_uri' => 'https://github.com/xlgmokha/net-hippie',
+    'rubygems_mfa_required' => 'true'
   }
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
@@ -26,9 +27,10 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
   spec.required_ruby_version = Gem::Requirement.new('>= 2.5.0')
 
+  spec.add_dependency 'logger', '~> 1.0'
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rubocop', '~> 0.55'
+  spec.add_development_dependency 'rubocop', '~> 1.9'
   spec.add_development_dependency 'vcr', '~> 6.0'
   spec.add_development_dependency 'webmock', '~> 3.4'
 end

README.md

@@ -1,7 +1,8 @@
 # Net::Hippie
 
 [![Gem Version](https://badge.fury.io/rb/net-hippie.svg)](https://rubygems.org/gems/net-hippie)
-[![Build Status](https://github.com/xlgmokha/net-hippie/workflows/Test/badge.svg)](https://github.com/xlgmokha/net-hippie/actions)
+[![Build Status](https://github.com/xlgmokha/net-hippie/actions/workflows/ci.yml/badge.svg))](https://github.com/xlgmokha/net-hippie/actions)
+
 
 `Net::Hippie` is a light weight wrapper around `net/http` that defaults to
 sending `JSON` messages.
@@ -65,6 +66,12 @@ client = Net::Hippie::Client.new(
 )
 ```
 
+To disable logging you will need to override the default logger.
+
+```ruby
+client = Net::Hippie::Client.new(logger: nil)
+```
+
 ### Basic Auth
 
 ```ruby