Commit ab0b8c7

mo <mo@mokhan.ca>
2018-10-20 18:36:55
fix some linter errors
1 parent 0e821c0
app/controllers/clients_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ClientsController < ApplicationController
   skip_before_action :authenticate!
   before_action :apply_cache_headers
app/models/client.rb
@@ -8,11 +8,11 @@ class Client < ApplicationRecord
   attribute :redirect_uris, :string, array: true
   enum token_endpoint_auth_method: { client_secret_none: 0, client_secret_post: 1, client_secret_basic: 2 }
 
-  validates :redirect_uris, presence: true#, format: { with: URI_REGEX }
+  validates :redirect_uris, presence: true
   validates :jwks_uri, format: { with: URI_REGEX }, allow_blank: true
   validates :logo_uri, format: { with: URI_REGEX }, allow_blank: true
   validates :name, presence: true
-  validates_each :redirect_uris do |record, attr, value|
+  validates_each :redirect_uris do |record, _attr, value|
     invalid_uri = Array(value).find { |x| !x.match?(URI_REGEX) }
     record.errors[:redirect_uris] << 'is invalid.' if invalid_uri
   end
@@ -35,7 +35,7 @@ class Client < ApplicationRecord
   end
 
   def valid_redirect_uri?(redirect_uri)
-    self.redirect_uris.include? redirect_uri
+    redirect_uris.include? redirect_uri
   end
 
   def valid_response_type?(response_type)
app/views/clients/create.json.jbuilder
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 json.client_id @client.to_param
 json.client_secret @client.password
 json.client_id_issued_at @client.created_at.to_i
db/migrate/20170101000000_enable_pg_extensions.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EnablePgExtensions < ActiveRecord::Migration[5.2]
   def change
     enable_extension 'uuid-ossp'
db/migrate/20181020161349_change_clients.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ChangeClients < ActiveRecord::Migration[5.2]
   def change
     add_column :clients, :redirect_uris, :text, array: true, default: [], null: false
spec/requests/clients_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe "/clients" do