Commit `d3d5860`

mo <mo.khan@gmail.com>

2018-10-22 01:34:10

remove 2 brakeman warnings

main

1 parent a10c094

Changed files (1)

app

controllers

oauth

authorizations_controller.rb

@@ -8,17 +8,11 @@ module Oauth
       @client = Client.find(secure_params[:client_id])
 
       unless @client.valid_redirect_uri?(secure_params[:redirect_uri])
-        return redirect_to @client.redirect_url(
-          error: :invalid_request,
-          state: secure_params[:state]
-        )
+        return redirect_to error_url_for(@client, :invalid_request)
       end
 
       unless @client.valid_response_type?(secure_params[:response_type])
-        return redirect_to @client.redirect_url(
-          error: :unsupported_response_type,
-          state: secure_params[:state]
-        )
+        return redirect_to error_url_for(@client, :unsupported_response_type)
       end
 
       session[:oauth] = secure_params.to_h
@@ -42,5 +36,12 @@ module Oauth
         :state, :code_challenge, :code_challenge_method
       )
     end
+
+    def error_url_for(client, type)
+      client.redirect_url(
+        error: type,
+        state: secure_params[:state]
+      )
+    end
   end
 end

Commit d3d5860

Commit `d3d5860`