Commit 4fb17d4

@@ -11,7 +11,7 @@ module Saml
           desc 'list', "List each of the registered entityId's"
           def list
             if registry.count.zero?
-              say 'Please register metadata using `saml-kit metadata register <url>`'
+              say('Register metadata using `saml-kit metadata register <url>`')
             end
             registry.each do |x|
               say x.entity_id, :green

@@ -12,7 +12,8 @@ module Saml
           shell.say_status :success, "Decoded #{document.send(:name)}"
           shell.print_table build_table_for(document)
           shell.say ''
-          if document.signature.present? && document.signature.certificate.present?
+          if document.signature.present? &&
+             document.signature.certificate.present?
             shell.say(document.signature.certificate.x509.to_text)
           end
           shell.say ''
@@ -39,8 +40,8 @@ module Saml
             table.push(['Issue Instant', document.issue_instant.iso8601])
             table.push(['Type', document.send(:name)])
             table.push(['Valid', document.valid?])
-            table.push(['Signed?', !!document.signed?])
-            table.push(['Trusted?', !!document.trusted?])
+            table.push(['Signed?', document.signed?])
+            table.push(['Trusted?', document.trusted?])
           when Saml::Kit::Metadata
             table.push(['Entity Id', document.entity_id])
             table.push(['Type', document.send(:name)])
@@ -65,11 +66,15 @@ module Saml
           if document.signature.present?
             signature = document.signature
             table.push(['Digest Value', signature.digest_value])
-            table.push(['Expected Digest Value', signature.expected_digest_value])
+            table.push([
+              'Expected Digest Value', signature.expected_digest_value
+            ])
             table.push(['Digest Method', signature.digest_method])
             table.push(['Signature Value', truncate(signature.signature_value)])
             table.push(['Signature Method', signature.signature_method])
-            table.push(['Canonicalization Method', signature.canonicalization_method])
+            table.push([
+              'Canonicalization Method', signature.canonicalization_method
+            ])
             table.push(['', signature.certificate.x509.to_text])
           end
           case document
@@ -82,7 +87,7 @@ module Saml
             table.push(['Assertion Present?', document.assertion.present?])
             table.push(['Issuer', document.assertion.issuer])
             table.push(['Name Id', document.assertion.name_id])
-            table.push(['Signed?', !!document.assertion.signed?])
+            table.push(['Signed?', document.assertion.signed?])
             table.push(['Attributes', document.assertion.attributes.inspect])
             table.push(['Not Before', document.assertion.started_at])
             table.push(['Not After', document.assertion.expired_at])
@@ -92,11 +97,17 @@ module Saml
             if document.assertion.present?
               signature = document.assertion.signature
               table.push(['Digest Value', signature.digest_value])
-              table.push(['Expected Digest Value', signature.expected_digest_value])
+              table.push([
+                'Expected Digest Value', signature.expected_digest_value
+              ])
               table.push(['Digest Method', signature.digest_method])
-              table.push(['Signature Value', truncate(signature.signature_value)])
+              table.push([
+                'Signature Value', truncate(signature.signature_value)
+              ])
               table.push(['Signature Method', signature.signature_method])
-              table.push(['Canonicalization Method', signature.canonicalization_method])
+              table.push([
+                'Canonicalization Method', signature.canonicalization_method
+              ])
               table.push(['', signature.certificate.x509.to_text])
             end
           end

@@ -1,4 +1,4 @@
-RSpec.describe Saml::Kit::Cli::Commands::Certificate do
+RSpec.describe Saml::Kit::Cli::Commands::Decode do
   describe '#redirect' do
     let(:command) { "decode redirect #{redirect_binding.serialize(builder)[0]}" }
     let(:document) { builder.build }

@@ -42,7 +42,7 @@ RSpec.describe Saml::Kit::Cli::Commands::Metadata do
 
     context 'when zero metadata is registered' do
       specify { expect(status).to be_success }
-      specify { expect(output).to include('Please register metadata using `saml-kit metadata register <url>`') }
+      specify { expect(output).to include('Register metadata using `saml-kit metadata register <url>`') }
     end
   end
 end

@@ -1,4 +1,4 @@
-RSpec.describe Saml::Kit::Cli::Commands::Certificate do
+RSpec.describe Saml::Kit::Cli::Commands::XmlDigitalSignature do
   describe '#verify' do
     let(:command) { "xmldsig verify #{tempfile}" }
     let(:tempfile) { Tempfile.new('saml-kit').path }
@@ -13,7 +13,7 @@ RSpec.describe Saml::Kit::Cli::Commands::Certificate do
     before { IO.write(tempfile, xml) }
     after { File.unlink(tempfile) }
 
-    context 'file is valid' do
+    context 'when the file is valid' do
       let(:document) { Saml::Kit::AuthenticationRequest.build(configuration: configuration) }
       let(:xml) { document.to_xml }
 
@@ -22,7 +22,7 @@ RSpec.describe Saml::Kit::Cli::Commands::Certificate do
       specify { expect(output).to include("success  #{tempfile} is valid") }
     end
 
-    context 'file is invalid' do
+    context 'when the file is invalid' do
       let(:document) { Saml::Kit::AuthenticationRequest.build(configuration: configuration) }
       let(:xml) { document.to_xml.gsub(/#{entity_id}/, 'hacked') }
 

@@ -1,6 +1,6 @@
 require 'english'
 
-RSpec.shared_context 'shell execution' do
+RSpec.shared_context 'when executing the cli' do
   subject { execute(command) }
 
   let(:status) { subject[0] }
@@ -16,5 +16,5 @@ RSpec.shared_context 'shell execution' do
 end
 
 RSpec.configure do |config|
-  config.include_context 'shell execution'
+  config.include_context 'when executing the cli'
 end