Commit d9e31d7

mokha <mokha@cisco.com>
2018-03-07 02:57:32
fix some rubocop errors.
1 parent a80ac8f
Changed files (2)
lib
saml
kit
core_ext
spec
saml
kit
cli
lib/saml/kit/core_ext/document.rb
@@ -59,7 +59,11 @@ module Saml
         table.push(['Organization', organization_name])
         table.push(['Url', organization_url])
         table.push(['Contact', contact_person_company])
-        %w[SingleSignOnService SingleLogoutService AssertionConsumerService].each do |type|
+        %w[
+          SingleSignOnService
+          SingleLogoutService
+          AssertionConsumerService
+        ].each do |type|
           services(type).each do |service|
             table.push([type, [service.location, service.binding]])
           end
spec/saml/kit/cli/commands/decode_spec.rb
@@ -1,4 +1,6 @@
 RSpec.describe Saml::Kit::Cli::Commands::Decode do
+  let(:user) { double(name_id_for: SecureRandom.uuid) }
+
   describe '#redirect' do
     let(:command) { "decode redirect #{redirect_binding.serialize(builder)[0]}" }
     let(:document) { builder.build }
@@ -39,7 +41,6 @@ RSpec.describe Saml::Kit::Cli::Commands::Decode do
           x.sign_with(Xml::Kit::KeyPair.generate(use: :signing))
         end
       end
-      let(:user) { double(name_id_for: SecureRandom.uuid) }
       let(:document) { builder.build }
 
       specify { expect(status).to be_success }
@@ -51,7 +52,6 @@ RSpec.describe Saml::Kit::Cli::Commands::Decode do
     context 'when the document is a LogoutRequest' do
       let(:command) { "decode post #{post_binding.serialize(builder)[1]['SAMLRequest']}" }
       let(:builder) { Saml::Kit::LogoutRequest.builder(user) }
-      let(:user) { double(name_id_for: SecureRandom.uuid) }
       let(:document) { builder.build }
 
       specify { expect(status).to be_success }
@@ -63,7 +63,7 @@ RSpec.describe Saml::Kit::Cli::Commands::Decode do
     context 'when the document is a LogoutResponse' do
       let(:command) { "decode post #{post_binding.serialize(builder)[1]['SAMLResponse']}" }
       let(:builder) { Saml::Kit::LogoutResponse.builder(request) }
-      let(:request) { double(id: Xml::Kit::Id.generate) }
+      let(:request) { instance_double(Saml::Kit::AuthenticationRequest, id: Xml::Kit::Id.generate) }
       let(:document) { builder.build }
 
       specify { expect(status).to be_success }