Commit 175a48a

mo <mo@mokhan.ca>
2017-11-02 18:05:27
move duplicate method to Namespaces module.
main
1 parent 054fbaf
Changed files (3)
lib
saml
kit
identity_provider_metadata.rb
namespaces.rb
service_provider_metadata.rb
lib/saml/kit/identity_provider_metadata.rb
@@ -38,11 +38,11 @@ module Saml
         end
 
         def add_single_sign_on_service(url, binding: :post)
-          @single_sign_on_urls.push(location: url, binding: binding_namespace_for(binding))
+          @single_sign_on_urls.push(location: url, binding: Namespaces.binding_for(binding))
         end
 
         def add_single_logout_service(url, binding: :post)
-          @logout_urls.push(location: url, binding: binding_namespace_for(binding))
+          @logout_urls.push(location: url, binding: Namespaces.binding_for(binding))
         end
 
         def to_xml
@@ -92,14 +92,6 @@ module Saml
             entityID: entity_id,
           }
         end
-
-        def binding_namespace_for(binding)
-          if :post == binding
-            Namespaces::POST
-          else
-            Namespaces::HTTP_REDIRECT
-          end
-        end
       end
     end
   end
lib/saml/kit/namespaces.rb
@@ -19,6 +19,14 @@ module Saml
       UNSPECIFIED = "urn:oasis:names:tc:SAML:2.0:consent:unspecified"
       URI = "urn:oasis:names:tc:SAML:2.0:attrname-format:uri"
       XMLDSIG = "http://www.w3.org/2000/09/xmldsig#"
+
+      def self.binding_for(binding)
+        if :post == binding
+          Namespaces::POST
+        else
+          Namespaces::HTTP_REDIRECT
+        end
+      end
     end
   end
 end
lib/saml/kit/service_provider_metadata.rb
@@ -29,11 +29,11 @@ module Saml
         end
 
         def add_assertion_consumer_service(url, binding: :post)
-          @acs_urls.push(location: url, binding: binding_namespace_for(binding))
+          @acs_urls.push(location: url, binding: Namespaces.binding_for(binding))
         end
 
         def add_single_logout_service(url, binding: :post)
-          @logout_urls.push(location: url, binding: binding_namespace_for(binding))
+          @logout_urls.push(location: url, binding: Namespaces.binding_for(binding))
         end
 
         def to_xml
@@ -86,13 +86,6 @@ module Saml
           }
         end
 
-        def binding_namespace_for(binding)
-          if :post == binding
-            Namespaces::POST
-          else
-            Namespaces::HTTP_REDIRECT
-          end
-        end
       end
     end
   end