Commit 1917c88
Changed files (3)
lib
spec
lib/saml/kit/authentication_request.rb
@@ -61,7 +61,7 @@ module Saml
def must_be_registered_service_provider
return unless login_request?
- return if service_provider.matches?(issuer, fingerprint)
+ return if service_provider.matches?(fingerprint)
errors[:base] << error_message(:invalid)
end
lib/saml/kit/service_provider_metadata.rb
@@ -14,11 +14,10 @@ module Saml
end
end
- def matches?(issuer, fingerprint)
- #issuer.present? && fingerprint.algorithm(OpenSSL::Digest::SHA256).present?
+ def matches?(fingerprint)
+ #fingerprint.algorithm(OpenSSL::Digest::SHA256).present?
end
-
private
class Builder
spec/saml/authentication_request_spec.rb
@@ -78,7 +78,7 @@ RSpec.describe Saml::Kit::AuthenticationRequest do
xml = builder.to_xml
fingerprint = Saml::Kit::Fingerprint.new(Hash.from_xml(xml)['AuthnRequest']['Signature']['KeyInfo']['X509Data']['X509Certificate'])
- allow(service_provider_metadata).to receive(:matches?).with(issuer, fingerprint).and_return(false)
+ allow(service_provider_metadata).to receive(:matches?).with(fingerprint).and_return(false)
expect(described_class.new(xml)).to be_invalid
end