Commit 2516202
2017-11-14 00:04:19
1 parent
09efda3
Changed files (4)
airport
app
controllers
saml-kit
lib
saml
spec
airport/app/controllers/sessions_controller.rb
@@ -18,7 +18,7 @@ class SessionsController < ApplicationController
end
def destroy
- @post_uri = idp_metadata.single_logout_service_for(:post)
+ @post_uri = idp_metadata.single_logout_service_for(binding: :post)
@saml_request = idp_metadata.build_request(Saml::Kit::LogoutRequest).serialize
end
saml-kit/lib/saml/kit/identity_provider_metadata.rb
@@ -22,7 +22,7 @@ module Saml
end
end
- def single_sign_on_service_for(binding)
+ def single_sign_on_service_for(binding:)
binding = Saml::Kit::Namespaces.binding_for(binding)
result = single_sign_on_services.find do |item|
item[:binding] == binding
saml-kit/lib/saml/kit/metadata.rb
@@ -62,7 +62,7 @@ module Saml
end
end
- def single_logout_service_for(binding)
+ def single_logout_service_for(binding:)
binding = Saml::Kit::Namespaces.binding_for(binding)
result = single_logout_services.find do |item|
item[:binding] == binding
saml-kit/spec/saml/identity_provider_metadata_spec.rb
@@ -233,8 +233,8 @@ RSpec.describe Saml::Kit::IdentityProviderMetadata do
end
it 'returns the binding that matches the requested' do
- expect(subject.single_sign_on_service_for(:post)).to eql(post_url)
- expect(subject.single_sign_on_service_for(:http_redirect)).to eql(redirect_url)
+ expect(subject.single_sign_on_service_for(binding: :post)).to eql(post_url)
+ expect(subject.single_sign_on_service_for(binding: :http_redirect)).to eql(redirect_url)
end
it 'returns nil if the binding cannot be found' do
@@ -295,12 +295,12 @@ RSpec.describe Saml::Kit::IdentityProviderMetadata do
end
it 'returns the location for the matching binding' do
- expect(subject.single_logout_service_for(:post)).to eql(post_url)
- expect(subject.single_logout_service_for(:http_redirect)).to eql(redirect_url)
+ expect(subject.single_logout_service_for(binding: :post)).to eql(post_url)
+ expect(subject.single_logout_service_for(binding: :http_redirect)).to eql(redirect_url)
end
it 'returns nil if the binding is not available' do
- expect(subject.single_logout_service_for(:soap)).to be_nil
+ expect(subject.single_logout_service_for(binding: :soap)).to be_nil
end
end
end