Commit 4f12933

mo <mo@mokhan.ca>
2017-11-22 21:19:50
:post -> :http_post
main
1 parent e04259d
Changed files (8)
lib
saml
kit
bindings.rb
logout_response.rb
response.rb
service_provider_metadata.rb
spec
saml
bindings
http_redirect_spec.rb
identity_provider_metadata_spec.rb
service_provider_metadata_spec.rb
xml_spec.rb
lib/saml/kit/bindings.rb
@@ -10,7 +10,6 @@ module Saml
       HTTP_POST = "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"
       HTTP_REDIRECT = "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect"
       ALL = {
-        post: HTTP_POST,
         http_post: HTTP_POST,
         http_redirect: HTTP_REDIRECT,
         http_artifact: HTTP_ARTIFACT,
lib/saml/kit/logout_response.rb
@@ -25,7 +25,7 @@ module Saml
           @issuer = configuration.issuer
           provider = configuration.registry.metadata_for(@issuer)
           if provider
-            @destination = provider.single_logout_service_for(binding: :post).try(:location)
+            @destination = provider.single_logout_service_for(binding: :http_post).try(:location)
           end
         end
lib/saml/kit/response.rb
@@ -158,9 +158,9 @@ module Saml
 
         def destination_for(request)
           if request.signed? && request.trusted?
-            request.acs_url || request.provider.assertion_consumer_service_for(binding: :post).try(:location)
+            request.acs_url || request.provider.assertion_consumer_service_for(binding: :http_post).try(:location)
           else
-            request.provider.assertion_consumer_service_for(binding: :post).try(:location)
+            request.provider.assertion_consumer_service_for(binding: :http_post).try(:location)
           end
         end
lib/saml/kit/service_provider_metadata.rb
@@ -35,11 +35,11 @@ module Saml
           @want_assertions_signed = true
         end
 
-        def add_assertion_consumer_service(url, binding: :post)
+        def add_assertion_consumer_service(url, binding: :http_post)
           @acs_urls.push(location: url, binding: Bindings.binding_for(binding))
         end
 
-        def add_single_logout_service(url, binding: :post)
+        def add_single_logout_service(url, binding: :http_post)
           @logout_urls.push(location: url, binding: Bindings.binding_for(binding))
         end
spec/saml/bindings/http_redirect_spec.rb
@@ -84,7 +84,7 @@ RSpec.describe Saml::Kit::Bindings::HttpRedirect do
 
     it 'returns a signed document, when a signature is missing' do
       builder = Saml::Kit::ServiceProviderMetadata::Builder.new
-      builder.add_assertion_consumer_service(FFaker::Internet.http_url, binding: :post)
+      builder.add_assertion_consumer_service(FFaker::Internet.http_url, binding: :http_post)
       provider = builder.build
       allow(Saml::Kit.configuration.registry).to receive(:metadata_for).with(issuer).and_return(provider)
spec/saml/identity_provider_metadata_spec.rb
@@ -71,9 +71,9 @@ RSpec.describe Saml::Kit::IdentityProviderMetadata do
     it 'valid when given valid identity provider metadata' do
       builder = described_class::Builder.new
       builder.attributes = [:email]
-      builder.add_single_sign_on_service(FFaker::Internet.http_url, binding: :post)
+      builder.add_single_sign_on_service(FFaker::Internet.http_url, binding: :http_post)
       builder.add_single_sign_on_service(FFaker::Internet.http_url, binding: :http_redirect)
-      builder.add_single_logout_service(FFaker::Internet.http_url, binding: :post)
+      builder.add_single_logout_service(FFaker::Internet.http_url, binding: :http_post)
       builder.add_single_logout_service(FFaker::Internet.http_url, binding: :http_redirect)
       expect(builder.build).to be_valid
     end
@@ -122,12 +122,12 @@ RSpec.describe Saml::Kit::IdentityProviderMetadata do
     subject do
       builder = Saml::Kit::IdentityProviderMetadata::Builder.new
       builder.add_single_sign_on_service(redirect_url, binding: :http_redirect)
-      builder.add_single_sign_on_service(post_url, binding: :post)
+      builder.add_single_sign_on_service(post_url, binding: :http_post)
       builder.build
     end
 
     it 'returns the POST binding' do
-      result = subject.single_sign_on_service_for(binding: :post)
+      result = subject.single_sign_on_service_for(binding: :http_post)
       expect(result.location).to eql(post_url)
       expect(result.binding).to eql(Saml::Kit::Bindings::HTTP_POST)
     end
@@ -174,11 +174,11 @@ RSpec.describe Saml::Kit::IdentityProviderMetadata do
 
     before :each do
       builder.add_single_logout_service(redirect_url, binding: :http_redirect)
-      builder.add_single_logout_service(post_url, binding: :post)
+      builder.add_single_logout_service(post_url, binding: :http_post)
     end
 
     it 'returns the location for the matching binding' do
-      expect(subject.single_logout_service_for(binding: :post).location).to eql(post_url)
+      expect(subject.single_logout_service_for(binding: :http_post).location).to eql(post_url)
       expect(subject.single_logout_service_for(binding: :http_redirect).location).to eql(redirect_url)
     end
 
@@ -205,7 +205,7 @@ RSpec.describe Saml::Kit::IdentityProviderMetadata do
         Saml::Kit::Namespaces::EMAIL_ADDRESS,
       ]
       subject.add_single_sign_on_service("https://www.example.com/login", binding: :http_redirect)
-      subject.add_single_logout_service("https://www.example.com/logout", binding: :post)
+      subject.add_single_logout_service("https://www.example.com/logout", binding: :http_post)
       subject.attributes << "id"
 
       result = Hash.from_xml(subject.build.to_xml)
spec/saml/service_provider_metadata_spec.rb
@@ -26,7 +26,7 @@ RSpec.describe Saml::Kit::ServiceProviderMetadata do
     XML
     it 'builds the service provider metadata' do
       subject.entity_id = entity_id
-      subject.add_assertion_consumer_service(acs_url, binding: :post)
+      subject.add_assertion_consumer_service(acs_url, binding: :http_post)
       subject.name_id_formats = [
         Saml::Kit::Namespaces::PERSISTENT,
         Saml::Kit::Namespaces::TRANSIENT,
@@ -59,9 +59,9 @@ RSpec.describe Saml::Kit::ServiceProviderMetadata do
     let(:builder) { described_class::Builder.new }
     subject do
       builder.entity_id = entity_id
-      builder.add_assertion_consumer_service(acs_post_url, binding: :post)
+      builder.add_assertion_consumer_service(acs_post_url, binding: :http_post)
       builder.add_assertion_consumer_service(acs_redirect_url, binding: :http_redirect)
-      builder.add_single_logout_service(logout_post_url, binding: :post)
+      builder.add_single_logout_service(logout_post_url, binding: :http_post)
       builder.add_single_logout_service(logout_redirect_url, binding: :http_redirect)
       builder.build
     end
@@ -106,9 +106,9 @@ RSpec.describe Saml::Kit::ServiceProviderMetadata do
     let(:service_provider_metadata) do
       builder = described_class::Builder.new
       builder.entity_id = entity_id
-      builder.add_assertion_consumer_service(acs_post_url, binding: :post)
+      builder.add_assertion_consumer_service(acs_post_url, binding: :http_post)
       builder.add_assertion_consumer_service(acs_redirect_url, binding: :http_redirect)
-      builder.add_single_logout_service(logout_post_url, binding: :post)
+      builder.add_single_logout_service(logout_post_url, binding: :http_post)
       builder.add_single_logout_service(logout_redirect_url, binding: :http_redirect)
       builder.to_xml
     end
spec/saml/xml_spec.rb
@@ -8,9 +8,9 @@ RSpec.describe Saml::Kit::Xml do
     let(:signed_xml) do
       builder = Saml::Kit::ServiceProviderMetadata::Builder.new
       builder.entity_id = FFaker::Movie.title
-      builder.add_assertion_consumer_service(login_url, binding: :post)
+      builder.add_assertion_consumer_service(login_url, binding: :http_post)
       builder.add_assertion_consumer_service(login_url, binding: :http_redirect)
-      builder.add_single_logout_service(logout_url, binding: :post)
+      builder.add_single_logout_service(logout_url, binding: :http_post)
       builder.add_single_logout_service(logout_url, binding: :http_redirect)
       builder.to_xml
     end