Commit 5a67683

mo <mo@mokhan.ca>
2017-12-04 16:52:32
add deprecation warning for removed method.
1 parent 1655428
Changed files (3)
lib/saml/kit/builders/authentication_request.rb
@@ -14,6 +14,16 @@ module Saml
           @sign = sign
         end
 
+        def acs_url
+          Saml::Kit.deprecate("acs_url is deprecated. Use assertion_consumer_service_url instead")
+          self.assertion_consumer_service_url
+        end
+
+        def acs_url=(value)
+          Saml::Kit.deprecate("acs_url= is deprecated. Use assertion_consumer_service_url= instead")
+          self.assertion_consumer_service_url = value
+        end
+
         def to_xml
           Signature.sign(sign: sign) do |xml, signature|
             xml.tag!('samlp:AuthnRequest', request_options) do
lib/saml/kit.rb
@@ -64,6 +64,11 @@ module Saml
       def registry
         configuration.registry
       end
+
+      def deprecate(message)
+        @deprecation ||= ActiveSupport::Deprecation.new('next-release', 'saml-kit')
+        @deprecation.deprecation_warning(message)
+      end
     end
   end
 end
spec/saml/builders/authentication_request_spec.rb
@@ -24,5 +24,10 @@ RSpec.describe Saml::Kit::Builders::AuthenticationRequest do
       expect(result['AuthnRequest']['Issuer']).to eql(issuer)
       expect(result['AuthnRequest']['NameIDPolicy']['Format']).to eql(Saml::Kit::Namespaces::PERSISTENT)
     end
+
+    it 'marks acs_url as deprecated' do
+      subject.acs_url = FFaker::Internet.uri('https')
+      expect(subject.assertion_consumer_service_url).to eql(subject.acs_url)
+    end
   end
 end