Commit 660f83b
Changed files (5)
spec
lib/saml/kit/authentication_request.rb
@@ -47,7 +47,7 @@ module Saml
def must_be_registered_service_provider
return unless login_request?
- return if Saml::Kit.configuration.service_provider_registry.registered?(issuer, fingerprint)
+ return if Saml::Kit.configuration.registry.registered?(issuer, fingerprint)
errors[:base] << error_message(:invalid)
end
lib/saml/kit/configuration.rb
@@ -7,15 +7,14 @@ module Saml
attr_accessor :issuer
attr_accessor :signature_method, :digest_method
attr_accessor :signing_certificate_pem, :signing_private_key_pem, :signing_private_key_password
- attr_accessor :service_provider_registry
+ attr_accessor :registry
def initialize
- #@issuer = SecureRandom.uuid
@signature_method = :SHA256
@digest_method = :SHA256
@signing_private_key_password = SecureRandom.uuid
@signing_certificate_pem, @signing_private_key_pem = SelfSignedCertificate.new(@signing_private_key_password).create
- @service_provider_registry = DefaultServiceProviderRegistry.new
+ @registry = DefaultRegistry.new
end
def stripped_signing_certificate
lib/saml/kit/default_service_provider_registry.rb → lib/saml/kit/default_registry.rb
@@ -1,6 +1,6 @@
module Saml
module Kit
- class DefaultServiceProviderRegistry
+ class DefaultRegistry
def registered?(issuer, fingerprint)
issuer.present? && fingerprint.algorithm(OpenSSL::Digest::SHA256).present?
end
lib/saml/kit.rb
@@ -12,7 +12,7 @@ require "xmldsig"
require "saml/kit/authentication_request"
require "saml/kit/configuration"
-require "saml/kit/default_service_provider_registry"
+require "saml/kit/default_registry"
require "saml/kit/fingerprint"
require "saml/kit/namespaces"
require "saml/kit/metadata"
spec/saml/authentication_request_spec.rb
@@ -69,7 +69,7 @@ RSpec.describe Saml::Kit::AuthenticationRequest do
builder.issuer = issuer
xml = builder.to_xml
- allow(Saml::Kit.configuration).to receive(:service_provider_registry).and_return(registry)
+ allow(Saml::Kit.configuration).to receive(:registry).and_return(registry)
fingerprint = Saml::Kit::Fingerprint.new(Hash.from_xml(xml)['AuthnRequest']['Signature']['KeyInfo']['X509Data']['X509Certificate'])
allow(registry).to receive(:registered?).with(issuer, fingerprint).and_return(false)
expect(described_class.new(xml)).to be_invalid