Commit 77dc9f8

mo <mo.khan@gmail.com>
2017-11-10 20:44:07
move serialize method to request.
1 parent 73608e4
Changed files (2)
lib
saml
spec
lib/saml/kit/request.rb
@@ -1,10 +1,6 @@
 module Saml
   module Kit
     class Request
-      def self.serialize(document)
-        Saml::Kit::Content.encode_raw_saml(document.to_xml)
-      end
-
       def self.deserialize(raw_request)
         request = Saml::Kit::Content.decode_raw_saml(raw_request)
         AuthenticationRequest.new(request)
spec/saml/request_spec.rb
@@ -1,18 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe Saml::Kit::Request do
-  describe ".serialize" do
-    subject { described_class }
-
-    it 'returns a compressed and base64 encoded document' do
-      xml = "<xml></xml>"
-      document = double(to_xml: xml)
-
-      expected_value = Base64.encode64(Zlib::Deflate.deflate(xml, 9)).gsub(/\n/, '')
-      expect(subject.serialize(document)).to eql(expected_value)
-    end
-  end
-
   describe ".deserialize" do
     subject { described_class }
     let(:issuer) { FFaker::Internet.http_url }
@@ -31,7 +19,7 @@ RSpec.describe Saml::Kit::Request do
     it 'decodes the raw_request' do
       builder = Saml::Kit::AuthenticationRequest::Builder.new
       builder.issuer = issuer
-      raw_saml = subject.serialize(builder)
+      raw_saml = builder.build.serialize
 
       result = subject.deserialize(raw_saml)
       expect(result.issuer).to eql(issuer)