Commit b1c6456

mo <mo.khan@gmail.com>
2017-12-17 20:01:19
mark the request as verified after signature is checked.
1 parent 56815f2
Changed files (1)
lib
saml
kit
lib/saml/kit/bindings/http_redirect.rb
@@ -18,7 +18,6 @@ module Saml
         def deserialize(params, configuration: Saml::Kit.configuration)
           document = deserialize_document_from!(params, configuration)
           ensure_valid_signature!(params, document)
-          document.signature_verified!
           document
         end
 
@@ -39,8 +38,11 @@ module Saml
             value.present? ? "#{key}=#{value}" : nil
           end.compact.join('&')
 
-          valid = document.provider.verify(algorithm_for(params['SigAlg']), signature, canonical_form)
-          raise ArgumentError.new("Invalid Signature") unless valid
+          if document.provider.verify(algorithm_for(params['SigAlg']), signature, canonical_form)
+            document.signature_verified!
+          else
+            raise ArgumentError.new("Invalid Signature")
+          end
         end
 
         def algorithm_for(algorithm)