Commit bb9cf8a
2017-11-10 20:44:07
1 parent
8f45a2a
Changed files (3)
airport
app
controllers
saml-kit
lib
saml
kit
spec
saml
airport/app/controllers/sessions_controller.rb
@@ -34,8 +34,6 @@ class SessionsController < ApplicationController
end
def authentication_request
- builder = Saml::Kit::AuthenticationRequest::Builder.new
- builder.acs_url = session_url
- Saml::Kit::Request.serialize(builder)
+ idp_metadata.build_authentication_request.serialize
end
end
saml-kit/lib/saml/kit/request.rb
@@ -1,10 +1,6 @@
module Saml
module Kit
class Request
- def self.serialize(document)
- Saml::Kit::Content.encode_raw_saml(document.to_xml)
- end
-
def self.deserialize(raw_request)
request = Saml::Kit::Content.decode_raw_saml(raw_request)
AuthenticationRequest.new(request)
saml-kit/spec/saml/request_spec.rb
@@ -1,18 +1,6 @@
require 'spec_helper'
RSpec.describe Saml::Kit::Request do
- describe ".serialize" do
- subject { described_class }
-
- it 'returns a compressed and base64 encoded document' do
- xml = "<xml></xml>"
- document = double(to_xml: xml)
-
- expected_value = Base64.encode64(Zlib::Deflate.deflate(xml, 9)).gsub(/\n/, '')
- expect(subject.serialize(document)).to eql(expected_value)
- end
- end
-
describe ".deserialize" do
subject { described_class }
let(:issuer) { FFaker::Internet.http_url }
@@ -31,7 +19,7 @@ RSpec.describe Saml::Kit::Request do
it 'decodes the raw_request' do
builder = Saml::Kit::AuthenticationRequest::Builder.new
builder.issuer = issuer
- raw_saml = subject.serialize(builder)
+ raw_saml = builder.build.serialize
result = subject.deserialize(raw_saml)
expect(result.issuer).to eql(issuer)