Commit d73a510

mo <mo.khan@gmail.com>
2018-02-26 01:20:15
fix rubocop errors.
1 parent cd5f7e2
lib/saml/kit/assertion.rb
@@ -50,8 +50,8 @@ module Saml
       end
 
       def attributes
-        @attributes ||= search("./saml:AttributeStatement/saml:Attribute").inject({}) do |memo, item|
-          memo[item.attribute("Name").value] = item.at_xpath('./saml:AttributeValue', Saml::Kit::Document::NAMESPACES).try(:text)
+        @attributes ||= search('./saml:AttributeStatement/saml:Attribute').inject({}) do |memo, item|
+          memo[item.attribute('Name').value] = item.at_xpath('./saml:AttributeValue', Saml::Kit::Document::NAMESPACES).try(:text)
           memo
         end.with_indifferent_access
       end
@@ -65,7 +65,7 @@ module Saml
       end
 
       def audiences
-        search("./saml:Conditions/saml:AudienceRestriction/saml:Audience").map(&:text)
+        search('./saml:Conditions/saml:AudienceRestriction/saml:Audience').map(&:text)
       end
 
       def encrypted?
spec/saml/kit/assertion_spec.rb
@@ -4,15 +4,16 @@ RSpec.describe Saml::Kit::Assertion do
       x.issuer = entity_id
     end.assertion
   end
-  let(:request) { instance_double(Saml::Kit::AuthenticationRequest, id: ::Xml::Kit::Id.generate, issuer: FFaker::Internet.uri("https"), assertion_consumer_service_url: FFaker::Internet.uri("https"), name_id_format: Saml::Kit::Namespaces::PERSISTENT, provider: nil, signed?: true, trusted?: true) }
+
+  let(:request) { instance_double(Saml::Kit::AuthenticationRequest, id: ::Xml::Kit::Id.generate, issuer: FFaker::Internet.uri('https'), assertion_consumer_service_url: FFaker::Internet.uri('https'), name_id_format: Saml::Kit::Namespaces::PERSISTENT, provider: nil, signed?: true, trusted?: true) }
   let(:user) { User.new(name_id: SecureRandom.uuid, attributes: { id: SecureRandom.uuid }) }
-  let(:entity_id) { FFaker::Internet.uri("https") }
+  let(:entity_id) { FFaker::Internet.uri('https') }
 
   specify { expect(subject.issuer).to eql(entity_id) }
   specify { expect(subject.name_id).to eql(user.name_id) }
   specify { expect(subject.started_at.to_i).to eql(Time.now.utc.to_i) }
   specify { expect(subject.expired_at.to_i).to eql(Saml::Kit.configuration.session_timeout.since(Time.now).utc.to_i) }
-  specify { expect(subject.attributes).to eql("id" => user.attributes[:id]) }
+  specify { expect(subject.attributes).to eql('id' => user.attributes[:id]) }
   specify { expect(subject.audiences).to match_array([request.issuer]) }
 
   describe '#active?' do
@@ -148,7 +149,7 @@ XML
     end
   end
 
-  describe "#encrypted?" do
+  describe '#encrypted?' do
     it 'returns true when encrypted' do
       key_pair = Xml::Kit::KeyPair.generate(use: :encryption)
       response = Saml::Kit::Response.build(user, request) do |x|
spec/saml/kit/document_spec.rb
@@ -5,8 +5,9 @@ RSpec.describe Saml::Kit::Document do
       x.issuer = issuer
     end
   end
+
   let(:id) { Xml::Kit::Id.generate }
-  let(:issuer) { FFaker::Internet.uri("https") }
+  let(:issuer) { FFaker::Internet.uri('https') }
 
   specify { expect(subject.id).to eql(id) }
   specify { expect(subject.issuer).to eql(issuer) }
.rubocop.yml
@@ -70,6 +70,9 @@ Naming/FileName:
 Style/Documentation:
   Enabled: false
 
+Style/EachWithObject:
+  Enabled: false
+
 Style/StringLiterals:
   EnforcedStyle: 'single_quotes'