Commit df87f1d

mo <mo@mokhan.ca>
2017-11-30 16:21:11
move response to new namespaces.
1 parent dfd11e1
lib/saml/kit/builders/response.rb
@@ -1,7 +1,7 @@
 module Saml
   module Kit
-    class Response < Document
-      class Builder
+    module Builders
+      class Response
         attr_reader :user, :request
         attr_accessor :id, :reference_id, :now
         attr_accessor :version, :status_code
@@ -42,7 +42,7 @@ module Saml
         end
 
         def build
-          Response.new(to_xml, request_id: request.id)
+          Saml::Kit::Response.new(to_xml, request_id: request.id)
         end
 
         private
lib/saml/kit/authentication_request.rb
@@ -16,7 +16,7 @@ module Saml
       end
 
       def response_for(user)
-        Response::Builder.new(user, self)
+        Saml::Kit::Builders::Response.new(user, self)
       end
     end
   end
spec/saml/bindings/http_post_spec.rb
@@ -77,7 +77,7 @@ RSpec.describe Saml::Kit::Bindings::HttpPost do
     it 'deserializes to a Response' do
       user = double(:user, name_id_for: SecureRandom.uuid, assertion_attributes_for: [])
       request = double(:request, id: SecureRandom.uuid, provider: nil, acs_url: FFaker::Internet.http_url, name_id_format: Saml::Kit::Namespaces::PERSISTENT, issuer: FFaker::Internet.http_url, signed?: true, trusted?: true)
-      builder = Saml::Kit::Response::Builder.new(user, request)
+      builder = Saml::Kit::Builders::Response.new(user, request)
       _, params = subject.serialize(builder)
       result = subject.deserialize(params)
       expect(result).to be_instance_of(Saml::Kit::Response)
spec/saml/bindings/http_redirect_spec.rb
@@ -48,7 +48,7 @@ RSpec.describe Saml::Kit::Bindings::HttpRedirect do
     it 'deserializes the SAMLResponse to a Response' do
       user = double(:user, name_id_for: SecureRandom.uuid, assertion_attributes_for: [])
       request = double(:request, id: SecureRandom.uuid, provider: nil, acs_url: FFaker::Internet.http_url, name_id_format: Saml::Kit::Namespaces::PERSISTENT, issuer: issuer, signed?: true, trusted?: true)
-      url, _ = subject.serialize(Saml::Kit::Response::Builder.new(user, request))
+      url, _ = subject.serialize(Saml::Kit::Builders::Response.new(user, request))
       result = subject.deserialize(query_params_from(url))
       expect(result).to be_instance_of(Saml::Kit::Response)
     end
spec/saml/builders/response_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-RSpec.describe Saml::Kit::Response::Builder do
+RSpec.describe Saml::Kit::Builders::Response do
   subject { described_class.new(user, request) }
   let(:email) { FFaker::Internet.email }
   let(:acs_url) { FFaker::Internet.uri("https") }
spec/saml/response_spec.rb
@@ -4,7 +4,7 @@ RSpec.describe Saml::Kit::Response do
   describe "#destination" do
     let(:acs_url) { "https://#{FFaker::Internet.domain_name}/acs" }
     let(:user) { double(:user, name_id_for: SecureRandom.uuid, assertion_attributes_for: []) }
-    subject { described_class::Builder.new(user, request).build }
+    subject { Saml::Kit::Builders::Response.new(user, request).build }
 
     describe "when the request is signed and trusted" do
       let(:request) { instance_double(Saml::Kit::AuthenticationRequest, id: SecureRandom.uuid, acs_url: acs_url, issuer: FFaker::Movie.title, name_id_format: Saml::Kit::Namespaces::EMAIL_ADDRESS, provider: nil, signed?: true, trusted?: true) }
@@ -29,7 +29,7 @@ RSpec.describe Saml::Kit::Response do
   describe "#valid?" do
     let(:request) { instance_double(Saml::Kit::AuthenticationRequest, id: "_#{SecureRandom.uuid}", issuer: FFaker::Internet.http_url, acs_url: FFaker::Internet.http_url, name_id_format: Saml::Kit::Namespaces::PERSISTENT, provider: nil, signed?: true, trusted?: true) }
     let(:user) { double(:user, name_id_for: SecureRandom.uuid, assertion_attributes_for: { id: SecureRandom.uuid }) }
-    let(:builder) { described_class::Builder.new(user, request) }
+    let(:builder) { Saml::Kit::Builders::Response.new(user, request) }
     let(:registry) { instance_double(Saml::Kit::DefaultRegistry) }
     let(:metadata) { instance_double(Saml::Kit::IdentityProviderMetadata) }