Commit e2109a1

mo <mo.khan@gmail.com>
2018-03-10 18:05:55
fix reek warning.
main
1 parent fc948ea
Changed files (2)
lib
saml
kit
assertion.rb
.reek
lib/saml/kit/assertion.rb
@@ -28,7 +28,7 @@ module Saml
         @cannot_decrypt = false
         @encrypted = false
         private_keys = (configuration.private_keys(use: :encryption) + private_keys).uniq
-        decrypt!(::Xml::Kit::Decryption.new(private_keys: private_keys))
+        decrypt(::Xml::Kit::Decryption.new(private_keys: private_keys))
       end
 
       def issuer
@@ -100,7 +100,7 @@ module Saml
 
       attr_reader :configuration
 
-      def decrypt!(decryptor)
+      def decrypt(decryptor)
         encrypted_assertion = at_xpath('./xmlenc:EncryptedData')
         @encrypted = encrypted_assertion.present?
         return unless @encrypted
.reek
@@ -63,7 +63,6 @@ ControlParameter:
   - Saml::Kit::Signature#to_xml
 PrimaDonnaMethod:
   exclude:
-  - Saml::Kit::Assertion
   - Saml::Kit::Bindings::HttpRedirect
   - Saml::Kit::Configuration
 TooManyInstanceVariables:
@@ -86,7 +85,7 @@ TooManyMethods:
 TooManyStatements:
   exclude:
   - initialize
-  - Saml::Kit::Assertion#decrypt!
+  - Saml::Kit::Assertion#decrypt
   - Saml::Kit::CompositeMetadata#services
   - Saml::Kit::DefaultRegistry::HttpApi#http
   - Saml::Kit::Metadata#from