Commit f8b962a

mo <mo@mokhan.ca>
2017-11-16 23:15:24
raise error when SAML* params is missing.
1 parent fadbb7a
Changed files (2)
lib
saml
spec
lib/saml/kit/binding.rb
@@ -38,6 +38,7 @@ module Saml
         elsif params['SAMLResponse'].present?
           Saml::Kit::Response.deserialize(CGI.unescape(params['SAMLResponse']))
         else
+          raise ArgumentError.new("SAMLRequest or SAMLResponse parameter is required.")
         end
       end
 
spec/saml/binding_spec.rb
@@ -121,6 +121,12 @@ RSpec.describe Saml::Kit::Binding do
         result = subject.deserialize({ 'SAMLResponse' => "nonsense" })
         expect(result).to be_instance_of(Saml::Kit::InvalidResponse)
       end
+
+      it 'raises an error when a saml parameter is not specified' do
+        expect do
+          subject.deserialize({ })
+        end.to raise_error(ArgumentError)
+      end
     end
   end
 end