Commit fba39b9

mo <mo.khan@gmail.com>
2018-03-10 18:32:50
extract variable.
1 parent fef2c2c
Changed files (2)
lib
saml
kit
lib/saml/kit/bindings/url_builder.rb
@@ -18,15 +18,16 @@ module Saml
         end
 
         def build(saml_document, relay_state: nil)
+          destination = saml_document.destination
           if configuration.sign?
             payload = canonicalize(saml_document, relay_state)
-            "#{saml_document.destination}?#{payload}&Signature=#{signature_for(payload)}"
+            "#{destination}?#{payload}&Signature=#{signature_for(payload)}"
           else
             payload = to_query_string(
               saml_document.query_string_parameter => serialize(saml_document.to_xml),
               'RelayState' => relay_state
             )
-            "#{saml_document.destination}?#{payload}"
+            "#{destination}?#{payload}"
           end
         end
 
.reek
@@ -89,7 +89,6 @@ LongParameterList:
 DuplicateMethodCall:
   exclude:
   - Saml::Kit::Bindings::Binding#saml_param_from
-  - Saml::Kit::Bindings::UrlBuilder#build
   - Saml::Kit::Builders::Response#initialize
   - Saml::Kit::XmlTemplatable#sign?
 FeatureEnvy: