Commit d9227f2

mo <mo@mokhan.ca>
2021-02-05 01:43:08
chore: run tests with Ruby 3.0 (#8)
* chore: run tests with Ruby 3.0 * feat: upgrade net-hippie * fix: upgrade *args to **args for Ruby 3 * chore: remove direct dependency on bundler
1 parent 9c7be35
.github/workflows/ci.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.5', '2.6', '2.7']
+        ruby-version: ['2.5', '2.6', '2.7', '3.0']
     steps:
       - uses: actions/checkout@v2
       - name: Set up Ruby
@@ -25,7 +25,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '2.7'
+          ruby-version: '3.0'
           bundler-cache: true
       - name: Running style checks…
         run: sh bin/style
@@ -35,7 +35,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '2.7'
+          ruby-version: '3.0'
           bundler-cache: true
       - name: Running audit…
         run: sh bin/audit
lib/scim/kit/v2/resource_type.rb
@@ -26,8 +26,8 @@ module Scim
         end
 
         class << self
-          def build(*args)
-            item = new(*args)
+          def build(**args)
+            item = new(**args)
             yield item
             item
           end
lib/scim/kit/v2/schema.rb
@@ -31,8 +31,8 @@ module Scim
         end
 
         class << self
-          def build(*args)
-            item = new(*args)
+          def build(**args)
+            item = new(**args)
             yield item
             item
           end
lib/scim/kit/http.rb
@@ -21,12 +21,13 @@ module Scim
       end
 
       def self.default_driver
-        @default_driver ||= Net::Hippie::Client.new(headers: headers).tap do |http|
-          http.logger = Scim::Kit.logger
-          http.open_timeout = 1
-          http.read_timeout = 5
-          http.follow_redirects = 3
-        end
+        @default_driver ||= Net::Hippie::Client.new(
+          follow_redirects: 3,
+          headers: headers,
+          logger: Scim::Kit.logger,
+          open_timeout: 1,
+          read_timeout: 5
+        )
       end
 
       def self.headers
Gemfile.lock
@@ -3,7 +3,7 @@ PATH
   specs:
     scim-kit (0.5.1)
       activemodel (~> 6.1)
-      net-hippie (~> 0.3)
+      net-hippie (~> 1.0)
       parslet (~> 2.0)
       tilt (~> 2.0)
       tilt-jbuilder (~> 0.7)
@@ -36,7 +36,7 @@ GEM
     jbuilder (2.11.2)
       activesupport (>= 5.0.0)
     minitest (5.14.3)
-    net-hippie (0.3.2)
+    net-hippie (1.1.1)
     parallel (1.20.1)
     parser (3.0.0.0)
       ast (~> 2.4.1)
@@ -89,10 +89,9 @@ GEM
     zeitwerk (2.4.2)
 
 PLATFORMS
-  ruby
+  x86_64-linux
 
 DEPENDENCIES
-  bundler (~> 2.0)
   bundler-audit (~> 0.6)
   ffaker (~> 2.7)
   rake (~> 13.0)
@@ -103,4 +102,4 @@ DEPENDENCIES
   webmock (~> 3.5)
 
 BUNDLED WITH
-   2.1.4
+   2.2.8
scim-kit.gemspec
@@ -31,11 +31,10 @@ Gem::Specification.new do |spec|
   spec.metadata['yard.run'] = 'yri'
 
   spec.add_dependency 'activemodel', '~> 6.1'
-  spec.add_dependency 'net-hippie', '~> 0.3'
+  spec.add_dependency 'net-hippie', '~> 1.0'
   spec.add_dependency 'parslet', '~> 2.0'
   spec.add_dependency 'tilt', '~> 2.0'
   spec.add_dependency 'tilt-jbuilder', '~> 0.7'
-  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'bundler-audit', '~> 0.6'
   spec.add_development_dependency 'ffaker', '~> 2.7'
   spec.add_development_dependency 'rake', '~> 13.0'