Commit d39839c

@@ -12,11 +12,9 @@ module TFA
     private
 
     def password_for(secret)
-      begin
-        ::ROTP::TOTP.new(secret).now
-      rescue
-        "???"
-      end  
+      ::ROTP::TOTP.new(secret).now
+    rescue ROTP::Base32::Base32Error => error
+      "INVALID SECRET"
     end
 
     def all_passwords

@@ -36,6 +36,17 @@ module TFA
           expect(subject.run(["blah"])).to be_empty
         end
       end
+
+      context "when the secret is invalid" do
+        let(:invalid_secret) { "hello world" }
+
+        it 'returns an error message' do
+          storage.save('development', invalid_secret)
+          expect(subject.run(["development"])).to eql([
+            { 'development' => "INVALID SECRET" }
+          ])
+        end
+      end
     end
   end
 end