Commit a130957

mo <mo.khan@gmail.com>
2018-03-03 18:56:07
shrink method size.
1 parent 4531798
Changed files (2)
lib/xml/kit/document.rb
@@ -58,17 +58,9 @@ module Xml
         return if find_by('//ds:Signature').nil?
 
         x509_certificates.each do |certificate|
-          inactive = now < certificate.not_before
-          if inactive
-            error_message = "Not valid before #{certificate.not_before}"
-            errors.add(:certificate, error_message)
-          end
+          errors.add(:certificate, "Not valid before #{certificate.not_before}") if now < certificate.not_before
 
-          expired = now > certificate.not_after
-          if expired
-            error_message = "Not valid after #{certificate.not_after}"
-            errors.add(:certificate, error_message)
-          end
+          errors.add(:certificate, "Not valid after #{certificate.not_after}") if now > certificate.not_after
         end
       end
 
.rubocop_todo.yml
@@ -10,11 +10,6 @@
 Metrics/AbcSize:
   Max: 18
 
-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 14
-
 # Offense count: 1
 Style/DoubleNegation:
   Exclude: